Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support chroot(relative_path_to_current_root) #17

Merged
merged 1 commit into from
May 28, 2018

Conversation

Hax4us
Copy link
Contributor

@Hax4us Hax4us commented May 26, 2018

It will fix this issue Hax4us/TermuxAlpine#1

@michalbednarski
Copy link
Collaborator

Thanks for pull request but I'm unable to see difference as chroot with relative path appears to be supported already. I've tested with termux-chroot with -0 option added to call and got successful result for all of those paths (Current dir is /home (a.k.a /data/data/com.termux/files/home), root is /data/data/com.termux/files):

..
../data/data/com.termux/files
/
/data/data/com.termux/files

As well as following after cd /data/data

./com.termux/files
com.termux/files
../..

Have I missed some case where chroot didn't work before and now works?

@SaavdhaanCyber
Copy link

translate(".") returns "/." rather than "/", when cwd is "/"
Which causes

/ # apk add zsh
(1/4) Installing ncurses-terminfo-base (6.0_p20170930-r0)
(2/4) Installing ncurses-terminfo (6.0_p20170930-r0)
(3/4) Installing ncurses-libs (6.0_p20170930-r0)
(4/4) Installing zsh (5.4.2-r0)
Executing zsh-5.4.2-r0.post-install
ERROR: zsh-5.4.2-r0.post-install: script exited with error 127
Executing busybox-1.27.2-r6.trigger
ERROR: busybox-1.27.2-r6.trigger: script exited with error 127
1 error; 17 MiB in 15 packages

@michalbednarski michalbednarski merged commit 02bc8d1 into termux:master May 28, 2018
@michalbednarski
Copy link
Collaborator

Thanks, now I could test it and appears to be working fine. I'm still working on other issues that are open but it'll take some time, so I'll be making now release with your fix.

michalbednarski added a commit to michalbednarski/termux-packages that referenced this pull request May 28, 2018
fornwall pushed a commit to termux/termux-packages that referenced this pull request May 29, 2018
@Neo-Oli
Copy link
Member

Neo-Oli commented Aug 10, 2018

Does this fix only work when /data/ is mounted? I am running into the same issue as Hax4us/TermuxAlpine#1, but I remove -b /data/data/com.termux/files/home from the proot command.

@gauloics
Copy link

still got busybox error on i686,
ERROR: busybox-1.28.4-r1.trigger: script exited with error 127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants