Add fixes for debug builds #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S_DEBUG Setting TERMUX_PKG_HAS_DEBUG=no disables attempt to build debug build of package. Useful for example if a debug build doesn't make sense, as for python-packages and texlive.
Configure script removes it otherwise.
Use strncpy instead of strcpy.
Original error message:
loslib.c:169:3: error: 'strcpy' called with string bigger than buffer
lua_tmpnam(buff, err);
^
loslib.c:122:37: note: expanded from macro 'lua_tmpnam'
strcpy(b, LUA_TMPNAMTEMPLATE); \
^
Debug build complained about the previous implicit declaration.
Debug build fails with: home/builder/.termux-build/libllvm/src/lib/Support/Unix/Path.inc:740:19: error: no matching function for call to 'RetryAfterSignal' if ((ResultFD = sys::RetryAfterSignal(-1, open, P.begin(), OpenFlags)) < 0)
Hopefully allows us to install debug packages without breaking dependecies. Should be looked over and be made more similar to how debian does this in any case
|
Nice, sorry for the delay! |
|
No worries. I should probably test this again, some patches might be redundant after the update to ndk r17. |
|
Hi!!is it possible to upgrade aapt to version 8.1?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add possiblity for debug patches (name them
*.patch.debug).Also add option
TERMUX_PKG_HAS_DEBUGwhich defaults to yes. Setting it to no makes build-package.sh skip debug build of package.All packages except libllvm builds with these fixes. I added
TERMUX_PKG_HAS_DEBUG=noto it for now.There was mostly two types of errors, either that
__attribute__((overloadable))needed to be added to strchr/strcpy/... or that-D_FORTIFY_SOURCE=2causes various errors (which probably has valid root causes that should be fixed).Apart from that there were some other different issues with some packages.
Most (but not all) of the debug patches work for normal builds as well but I've added them as debug patches to not break something by mistake.
We should look over the debug build process, and make it more similar to how debian does it (which I still don't quite understand. The current setup with TERMUX_PKG_REPLACES and renaming to -dbg is not really working fully.