Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby: update to 2.7.0 #5025

Merged
5 commits merged into from
Mar 15, 2020
Merged

ruby: update to 2.7.0 #5025

5 commits merged into from
Mar 15, 2020

Conversation

ghost
Copy link

@ghost ghost commented Mar 12, 2020

No description provided.

@ghost ghost added the WIP Work in progress, do not close the issue (PR) label Mar 12, 2020
@zorro
Copy link
Contributor

zorro commented Mar 15, 2020

May be related to https://bugs.ruby-lang.org/issues/16455

@ghost
Copy link
Author

ghost commented Mar 15, 2020 •
edited by ghost
Loading

@zorro This is for ARM. On AArch64 is another problem, not shown in CI logs.

/usr/bin/ruby --disable=gems -I/home/builder/.termux-build/ruby/build -raarch64-linux-android-fake  -I`cd /home/builder/.termux-build/ruby/src/lib; pwd` --disable-gems -r./aarch64-linux-android-fake /home/builder/.termux-build/ruby/src/tool/rbinstall.rb --make="make" --dest-dir="" --extout=".ext" --mflags="" --make-flags="" --data-mode=0644 --prog-mode=0755 --installed-list .installed.list --mantype="doc" --rdoc-output=".ext/rdoc" --html-output=".ext/html"
/usr/lib/ruby/vendor_ruby/rubygems/defaults/operating_system.rb:10: warning: constant Gem::ConfigMap is deprecated
Traceback (most recent call last):
	17: from /home/builder/.termux-build/ruby/src/tool/rbinstall.rb:644:in `<main>'
	16: from /home/builder/.termux-build/ruby/src/tool/rbinstall.rb:708:in `<module:RbInstall>'
	15: from /home/builder/.termux-build/ruby/src/lib/rubygems/core_ext/kernel_require.rb:72:in `require'
	14: from /home/builder/.termux-build/ruby/src/lib/rubygems/core_ext/kernel_require.rb:72:in `require'
	13: from /home/builder/.termux-build/ruby/src/lib/rubygems/installer.rb:12:in `<top (required)>'
	12: from /home/builder/.termux-build/ruby/src/lib/rubygems/core_ext/kernel_require.rb:72:in `require'
	11: from /home/builder/.termux-build/ruby/src/lib/rubygems/core_ext/kernel_require.rb:72:in `require'
	10: from /home/builder/.termux-build/ruby/src/lib/rubygems/ext.rb:16:in `<top (required)>'
	 9: from /home/builder/.termux-build/ruby/src/lib/rubygems/core_ext/kernel_require.rb:72:in `require'
	 8: from /home/builder/.termux-build/ruby/src/lib/rubygems/core_ext/kernel_require.rb:72:in `require'
	 7: from /home/builder/.termux-build/ruby/src/lib/rubygems/ext/ext_conf_builder.rb:9:in `<top (required)>'
	 6: from /home/builder/.termux-build/ruby/src/lib/rubygems/core_ext/kernel_require.rb:72:in `require'
	 5: from /home/builder/.termux-build/ruby/src/lib/rubygems/core_ext/kernel_require.rb:72:in `require'
	 4: from /home/builder/.termux-build/ruby/src/lib/tempfile.rb:8:in `<top (required)>'
	 3: from /home/builder/.termux-build/ruby/src/lib/rubygems/core_ext/kernel_require.rb:72:in `require'
	 2: from /home/builder/.termux-build/ruby/src/lib/rubygems/core_ext/kernel_require.rb:72:in `require'
	 1: from /home/builder/.termux-build/ruby/src/lib/delegate.rb:39:in `<top (required)>'
/home/builder/.termux-build/ruby/src/lib/delegate.rb:78:in `<class:Delegator>': undefined method `ruby2_keywords' for Delegator:Class (NoMethodError)
make: *** [uncommon.mk:373: do-install-all] Error 1

@ghost ghost merged commit bace80c into master Mar 15, 2020
@ghost ghost deleted the update-ruby branch March 15, 2020 21:27
@ghost ghost removed the WIP Work in progress, do not close the issue (PR) label Mar 16, 2020
Grimler91 pushed a commit that referenced this pull request Sep 6, 2021
@xtkoba @Grimler91
Remove --with-coroutine=copy from configure args
87ca46c 
The configure argument `--with-coroutine=copy` was added because in the era of version 2.7 Ruby was defaulted to using `ucontext` for coroutine implementation on ARMv7, causing a build issue (#5025). Now this configure argument is no longer necessary because Ruby version 3.0 (or later) by default uses "native" coroutine implementation for ARMv7 (and also for other three archs supported by Android).

Furthermore, `copy` coroutine implementation has its own deficiencies and is planned to be removed from Ruby 3.1 (https://bugs.ruby-lang.org/issues/18015). I see no reason to use `copy` coroutine where a working native implementation is available.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zorro