Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation and future disabling of playstore builds warning to banner #7493

Conversation

agnostic-apollo
Copy link
Member

@agnostic-apollo agnostic-apollo commented Sep 8, 2021

Sorry for the duplicate. I forgot to re-commit before force pushing after undoing the single commit.

@Grimler91 and @buttaface thanks for the suggestions. I have tried to incorporate them from both of you. Its slightly shorter and will show even if banner is disabled.

I can't really say "The termux apps will be removed from Play store", since that requires involvement from @fornwall, who hasn't been responding on emails/sms.

I have updated https://github.com/termux/termux-app#installation as well and added deprecation details.

Let me know of any further changes.

playstore-banner

@Grimler91
Copy link
Member

Looks good!

This:

.. so that new users
cannot install them and to **disable** them for
existing users with updates so that they do not
continue using outdated versions.

could be modified to make it clear who "they" are in the second part of the sentence. Perhaps:

.. so that new users
cannot install them and to **disable** them for
existing users with app updates to prevent the use 
of outdated app versions.

@agnostic-apollo agnostic-apollo force-pushed the change-banner-for-playstore-builds branch from d800a48 to d1a911b Compare September 8, 2021 23:26
@agnostic-apollo
Copy link
Member Author

@Grimler91 Done!

If someone else doesn't suggest changes in next few hours, I'll bump termux-tools version.

@RalfWerner
Copy link

Do it, even if I do not mean playstore users have an advantage of it.

nikooseyfi07

This comment was marked as spam.

Bryant-Coulson93

This comment was marked as spam.

Bryant-Coulson93

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants