Use completion hook to manage node module inside require function. #348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here a patch which manages completion of node module which uses your "completion" hook.
Ex :
I don't know if it's a clean mean to manage module completion (inside string).
Here some info about this patch :
I had to modify resolveProjectPath function to support WebBrowser context where server.options.projectDir is null.
In the moduleCompletion hook, I do callee.name === 'require' to check we are inside a string of require function. I don't know if it's clean mean.
When completion is opened, it shows modules and other keyword like setInterval, setTimeout...(which are not modules). It should be cool if we could avoid having those keyword which are not modules.
An idea is that hook function moduleCompletion could returns a boolean which tells "don't show other keywords than modules". What do you think about that?