Add dependency version management using dep #30
Conversation
The change would allow to have better control over the dependencies and their changing versions. The change includes: - Addition of Gopkg.lock and Gopkg.toml - Ignoring vendor/ directory - README changes to reflect the change - CI build scripts updates.
|
I am aware the CI has failed and I'm looking into it. |
|
|
||
| [[constraint]] | ||
| branch = "master" | ||
| name = "github.com/pyToshka/go-virtualbox" |
There was a problem hiding this comment.
Could you update this dependency to the root repo? The pyToshka version is a fork. I have pulled in all the changes from this fork in the root repo:
root repo = github.com/terra-farm/go-virtualbox
There was a problem hiding this comment.
It was generated by dep init based on the code in the repo at the time, specifically:
https://github.com/terra-farm/terraform-provider-virtualbox/blob/master/provider/resource_vm.go#L17
If someone wants to file a PR to change the package (or I can do it), I will update the PR.
There was a problem hiding this comment.
I will leave it for now. Let's get the build working so that this can be merged.
Gopkg.lock
Outdated
| "lex/httplex", | ||
| "trace" | ||
| ] | ||
| revision = "f2499483f923065a842d38eb4c7f1927e6fc6e6d" |
There was a problem hiding this comment.
@VoyTechnology this revision of net/http2 does not contain the function SetReuseFrames. Can you update this revision manually to ffcf1bedda3b04ebb15a168a59800a73d6dc0f4d and try again?
I got this revision from another project on Github using net/http2 with the function SetReuseFrames
https://github.com/SolarisYan/grpc-hello-with-gateway/blob/master/vendor/manifest
This ensures the package is built with latest version of the code for all the dependencies.
|
My last commit fixed the issue. However |
|
@VoyTechnology I merged this PR for now. If you still want to add caching, feel free to create a new PR. Thanks already for providing the |
The change would allow to have better control over the dependencies and
their changing versions.