Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] fix wasm rawkey querier & export command & bytecode commands #544

Merged
merged 7 commits into from
Sep 17, 2021

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Aug 30, 2021

Summary of changes

close #543
close #549

API changes

  • /wasm/contracts/{contractAddress}/store/raw: now receives a single param key, which is encoded with base64. The requester has to prefix the key length if needed.

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo added bug Something isn't working client rest / cli code improvements labels Aug 30, 2021
@yun-yeo yun-yeo requested a review from hanjukim August 30, 2021 08:11
@yun-yeo yun-yeo self-assigned this Aug 30, 2021
@yun-yeo yun-yeo changed the title [Bugfix] fix wasm rawkey querier to recevive base64 instead ascii string [Bugfix] fix wasm rawkey querier to allow base64 instead ascii string Aug 30, 2021
@yun-yeo yun-yeo changed the title [Bugfix] fix wasm rawkey querier to allow base64 instead ascii string [Bugfix] fix wasm rawkey querier to allow base64, not ascii string Aug 30, 2021
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #544 (eebb3f0) into main (28aa765) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #544      +/-   ##
==========================================
+ Coverage   44.88%   44.91%   +0.02%     
==========================================
  Files         118      118              
  Lines        6829     6829              
==========================================
+ Hits         3065     3067       +2     
+ Misses       3527     3526       -1     
+ Partials      237      236       -1     
Impacted Files Coverage Δ
x/oracle/tally.go 91.89% <0.00%> (+5.40%) ⬆️

@yun-yeo yun-yeo changed the title [Bugfix] fix wasm rawkey querier to allow base64, not ascii string [Bugfix] fix wasm rawkey querier & export command & bytecode commands Sep 1, 2021
@yun-yeo yun-yeo merged commit ea2849c into main Sep 17, 2021
@yun-yeo yun-yeo deleted the bugfix/wasm-raw-key-querier branch September 17, 2021 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client rest / cli code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] fix wasm cli & home dir issue in export command [BUG] wasm raw key interface should allow base64
1 participant