Fix CLIKey and Extension.isAvailable #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(extension): change different window variable for isAvailable
hanjukim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version will be updated to 1.0.0 to follow https://semver.org/ standard.
CLIKey
IgnorePlugin cannot ignore source code line for importing CLIKey which leads browser to raise an exception. To fix this problem, CLIKey was removed from
index. Developer have to explicitly import CLIKey from now on.Extension
Extension.isAvailable was using
window.Terra.isAvailablevariable to determine whether there's Terra Station Extension installed or not, assigned by Terra Station Extension.However, there will be a conflict on
window.Terrawhen terra.js is included by using <script> tag