feat: Add EFS performance settings. #339
Conversation
Adding EFS performance settings as the default EFS performance settings might not provide enough performance to initial Atlantis installs that have to pull large repos while the EFS volume is small as the default mode provides performance relative to disk usage. In testing the default EFS mode provided initial performance so far away from ephemeral storage that Atlantis became unusable.
|
In addition to my inline comment there is an important not regaring the use of the provisioned throuhgput type in the AWS docs https://docs.aws.amazon.com/efs/latest/ug/managing-throughput.html It is probably prudent to add that note to our README as well |
|
@antonbabenko could you review or point to who should be doing reviews for this repo? |
|
I don't think the failing checks are the fault of this PR. Is there anything more I can do? |
|
This is definitely beneficial |
|
Please fix the failing CI checks and it looks good to be merged. |
|
As far as I can see the CI checks that are failing have nothing to do with the changes i've made and are checking for older Terraform versions. Have I missed something? |
|
@lazzurs https://github.com/terraform-aws-modules/terraform-aws-atlantis/actions/runs/4620640384/jobs/8171227679?pr=339 - the code in |
@antonbabenko I think this is fixed in current master branch of module and @lazzurs just has to rebase from it and it should fix the issue. |
## [3.27.0](v3.26.1...v3.27.0) (2023-05-12) ### Features * Add EFS performance settings. ([#339](#339)) ([ba3ecf9](ba3ecf9))
|
This PR is included in version 3.27.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Adding EFS performance settings as the default EFS performance settings
might not provide enough performance to initial Atlantis installs that
have to pull large repos while the EFS volume is small as the default
mode provides performance relative to disk usage.
Motivation and Context
In testing the default EFS mode provided initial performance so far away
from ephemeral storage that Atlantis became unusable.
Breaking Changes
None
How Has This Been Tested?
The current examples do not use EFS so did not updated them with these
parameters.
pre-commit run -aon my pull request