feat: Configurable default action https listener #391
Conversation
Make the ALB https listener default action configurable
aalvarezaph
changed the title
|
@bryantbiggs sorry for tagging you, but is there anything else needed from my side? |
bryantbiggs
merged commit 7e75eec
into
terraform-aws-modules:master
## [4.1.0](v4.0.8...v4.1.0) (2024-01-18) ### Features * Configurable default action https listener ([#391](#391)) ([7e75eec](7e75eec))
|
This PR is included in version 4.1.0 🎉 |
|
@antonbabenko how is this propagated to Terraform registry? (registry still shows |
|
its usually automatic based on the tags created - looks like the registry didn't catch those or pick those up. Anton should be able to re-sync it when he gets a chance, looks like 4.2.0 should be latest |
Thx for the heads up! |
|
It is fixed by resyncing. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Make the ALB https listener default action configurable
Description
This PR adds a new variable
alb_https_default_actionthat allows configuring the default action for the ALB https listener.Motivation and Context
In my scenario, I wanted the default action to be a blocking one (send a fixed response instead of forwarding to Atlantis target group).
The reason for it is that I'm adding a rule that grants access through OIDC Authentication, but for that to make sense I need to have a default rule that doesn't forward.
Currently, this default action is hardcoded so this PR adds a variable to allow overriding it.
Breaking Changes
No breaking change, the new variable defaults to the value that preserves current behaviour
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request