Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Converting type of default_capacity_provider_strategy from map to list #28

Merged
merged 4 commits into from
Jan 26, 2021
Merged

Conversation

sumit-sampang-rai
Copy link
Contributor

@sumit-sampang-rai sumit-sampang-rai commented Jan 26, 2021

Description

As the description of the variable says the default can be one or more. Also, the ECS supports multiple defaults, the changes have been made.

Motivation and Context

It allows to add multiple default capacity provider strategy for the ECS services.
Screenshot 2021-01-26 at 10 34 25

Breaking Changes

The values of default_capacity_provider_strategy must now be enclosed inside list [].

How Has This Been Tested?

I made the changes on my local module and applied terraform plan.

@sumit-sampang-rai sumit-sampang-rai changed the title Converting type of default_capacity_provider_strategy from map to list fix: Converting type of default_capacity_provider_strategy from map to list Jan 26, 2021
@antonbabenko antonbabenko merged commit 44670f5 into terraform-aws-modules:master Jan 26, 2021
@antonbabenko
Copy link
Member

Thank you for the fix!

v2.6.0 has been just released.

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants