Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Update lambda module to 3.1.0 to support AWS provider version 4.8+ #166

Merged

Conversation

mattoddie
Copy link
Contributor

Description

Due to the breaking changes in AWS provider 4.x, the lambda module used as part of this module has been updated to 3.x to support the new provider. To allow this module to be used with the new provider, we need to update the lambda module version.

Motivation and Context

This updates the dependent lambda module to version 3.x, allowing this module to be used with AWS provider 4.x.

Breaking Changes

This is a breaking change as it is no longer compatible with AWS provider 3.x.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have executed pre-commit run -a on my pull request

@mattoddie mattoddie changed the title feat: update lambda module to 3.1 to support AWS provider 4.x feat: Update lambda module to 3.1 to support AWS provider 4.x Mar 30, 2022
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Could you please apply these fixes and update the docs?

main.tf Outdated Show resolved Hide resolved
examples/notify-slack-simple/versions.tf Outdated Show resolved Hide resolved
versions.tf Outdated Show resolved Hide resolved
examples/cloudwatch-alerts-to-slack/versions.tf Outdated Show resolved Hide resolved
@antonbabenko antonbabenko changed the title feat: Update lambda module to 3.1 to support AWS provider 4.x feat!: Update lambda module to 3.1.0 to support AWS provider version 4.8+ Mar 30, 2022
@mattoddie
Copy link
Contributor Author

@antonbabenko fixes applied and docs updated

@antonbabenko antonbabenko merged commit ea822a3 into terraform-aws-modules:master Mar 31, 2022
@antonbabenko
Copy link
Member

Thanks @mattoddie !

antonbabenko pushed a commit that referenced this pull request Mar 31, 2022
## [5.0.0](v4.24.0...v5.0.0) (2022-03-31)

### ⚠ BREAKING CHANGES

* - Update lambda module to 3.1.0 to support AWS provider version 4.8+

### Features

* Update lambda module to 3.1.0 to support AWS provider version 4.8+ ([#166](#166)) ([ea822a3](ea822a3))
@antonbabenko
Copy link
Member

This PR is included in version 5.0.0 🎉

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants