Simplify default security group lookup

[shemau]

Description

To address internal issue 6157. The lookup of the default security group is unnecessarily complex. Avoid looking up all VPCs and finding the right one based on the supplied vpc_id. Just look up the one VPC using the vpc_id.

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

There are no resource changes, so no impact to customers.

It is possible that the data resource for all VPC may show as being removed from the state file. However, as a data resource there are no resource changes.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[shemau]

/run pipeline

[ocofaigh]

@shemau can you resolve conflicts and re-run please? You can ignore the authorization policy error that occurred in last run - there was a parallel test running which caused conflict

[shemau]

/run pipeline

[shemau]

/run pipeline

[terraform-ibm-modules-ops]

🎉 This PR is included in version 2.12.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀