Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make cloud_services optional #442

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

shemau
Copy link
Contributor

@shemau shemau commented Nov 13, 2023

Description

cloud_services variable has no default value. This means that it MUST be specified as empty list if it is not used.

Example use case:
terraform-ibm-icd-postgresql example creates a VPE gateway using cloud_services_by_crn. It would be nice not to have to specify an empty list for cloud_services in this use case.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Required property is made optional, so there should be no changes required by consumer.
When this is released, consider updating the release notes of version 4.0 with the details of this bug. Some use cases, where cloud_services is not required might want to upgrade from 3.2 to 4.0.x (or higher) and avoid 4.0.0.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@shemau
Copy link
Contributor Author

shemau commented Nov 13, 2023

/run pipeline

@vburckhardt vburckhardt changed the title Make cloud_services optional fix: make cloud_services optional Nov 13, 2023
@vburckhardt vburckhardt merged commit 8c53528 into main Nov 13, 2023
2 checks passed
@vburckhardt vburckhardt deleted the cloud-service-optional branch November 13, 2023 16:04
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 4.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants