-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added default tags functionality #489
feat: Added default tags functionality #489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution.
Left some comments. Feel free to ask questions.
Thank you @wata727 for reviewing this! And thank you @JorgeReus for adding this. Please see the comments above. I would love to see this in the next version of this ruleset as many people will start using |
Hey there! Thanks for the review @wata727, didn't had much time last week to fix the PR, but hopefully I will this one. @nitrocode Sure! Will do my best. |
- Removed deprecated runner.EnsureNoError calls - Removed explicit pass of types to EvaluateExpr calls
Done fixing the comments, thanks @wata727! |
5f97fb9
to
2a3e7ba
Compare
Done for the second round of checks! Still familiarizing with the runner API, thanks! BTW, I downloaded the |
bc62fd4
to
38c30c6
Compare
Yes, we don't want to include irrelevant changes in this PR, so please rebase or clean up the diff. |
d5fd8d6
to
8b722a2
Compare
2f5ddc3
to
467e17e
Compare
- Added the RaiseErr field in the test table struct, this is due to having the ability of checking errors apart of helper issues, also checked if the provider existed using the mentioned mechanism - Erased unecessary error checking when decoding provider config
467e17e
to
c701a28
Compare
Done with the git wizardry, and thanks again for the review! LMK if more changes need to be made! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
Awesome! Nice work all! |
Hmm this test fails after this PR merged https://github.com/terraform-linters/tflint-ruleset-aws/actions/runs/5256902432/jobs/9498886637
Unsure if it's related to this PR or something else in the code base. Edit: nvm, it looks like it failed in the last 3 PR merges - this one and 2 dependabot PRs #498 #497 https://github.com/terraform-linters/tflint-ruleset-aws/commits/master |
Default Tags functionality added into the missing tags rule
I've added the functionality and tests to allow using default tags and not come across into errors. I work with a lot of repos in which we comply with the tagging standard using
default_tags
.This functionality will help us to detect uncompliant resources before we deploy them (we use cloud custodian)
Instead of creating an extra rule, I updated the existing one, this due to the keep only one rule regarding missing tags and allow others to use this feature without adding another rule to the tflint config.
LMK if any changes need to be made
fixes: #192