Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_storagegateway_gateway - add cloudwatch logs support #10939

Merged
merged 7 commits into from
Jan 29, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10681

Release note for CHANGELOG:

- resource/resource_aws_storagegateway_gateway: add `cloudwatch_log_group_arn` argument

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSStorageGatewayGateway_CloudWatchLogs'
=== RUN   TestAccAWSStorageGatewayGateway_CloudWatchLogs
=== PAUSE TestAccAWSStorageGatewayGateway_CloudWatchLogs
=== CONT  TestAccAWSStorageGatewayGateway_CloudWatchLogs
--- PASS: TestAccAWSStorageGatewayGateway_CloudWatchLogs (626.72s)

...

@DrFaust92 DrFaust92 requested a review from a team November 19, 2019 21:15
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. service/storagegateway Issues and PRs that pertain to the storagegateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Nov 19, 2019
@midacts
Copy link

midacts commented Jan 14, 2020

@bflad - sorry to ping you directly (you are the top contributor /flex)
I was wondering if this PR can be reviewed and merged.

Do you think it can make it into the v2.45.0 release?

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 29, 2020
@bflad bflad self-assigned this Jan 29, 2020
@bflad bflad added this to the v2.47.0 milestone Jan 29, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Cached (157.78s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Stored (158.83s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Vtl (167.86s)
--- PASS: TestAccAWSStorageGatewayGateway_tags (178.23s)
--- PASS: TestAccAWSStorageGatewayGateway_CloudWatchLogs (189.84s)
--- PASS: TestAccAWSStorageGatewayGateway_SmbGuestPassword (214.05s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_FileS3 (217.59s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayName (221.18s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayTimezone (221.59s)
--- PASS: TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings (656.20s)

@bflad bflad merged commit 150ccfd into hashicorp:master Jan 29, 2020
bflad added a commit that referenced this pull request Jan 29, 2020
@ghost
Copy link

ghost commented Jan 30, 2020

This has been released in version 2.47.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/storagegateway Issues and PRs that pertain to the storagegateway service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Storage Gateway - add support for Gateway Log Group
3 participants