Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMSS: ensuring we always set the vhd_containers field #1411

Merged
merged 1 commit into from
Jul 3, 2018

Conversation

tombuildsstuff
Copy link
Contributor

Issue #1043 shows a Diff Mismatch where the vhd_containers field isn't set; this PR fixes that by ensuring the field is always set.

Fixes #1043

@tombuildsstuff tombuildsstuff added bug service/vmss Virtual Machine Scale Sets labels Jun 19, 2018
@tombuildsstuff tombuildsstuff added this to the 1.8.0 milestone Jun 19, 2018
@tombuildsstuff tombuildsstuff requested a review from a team June 19, 2018 13:51
@mbfrahry
Copy link
Member

Do you mind throwing a test on this? I'd just like to see that extra bit of confirmation that the issue is fixed

@tombuildsstuff
Copy link
Contributor Author

Looking into adding a test for this - since this is a set with a dynamic computed value (since the storage account name is being used, which has to be globally unique) - I don't think there's an easy way of computing this:

  storage_profile_os_disk.1237888334.vhd_containers.#:                                          "" => "1"
  storage_profile_os_disk.1237888334.vhd_containers.1346120568:                                 "" => "https://tomdevvmsssa21.blob.core.windows.net/vhds"
  tags.%:                                                                                       "" => "<computed>"

As such I'm going to suggest we merge this without a test specifically for this, since the Import tests are covering it?

Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nested sets are a pain for testing, but I've personally used similar fixes. The import testing should cover this at least from the "no worse" standpoint. LGTM if the existing acceptance testing is happy. 👍

@tombuildsstuff
Copy link
Contributor Author

Tests pass:

screenshot 2018-07-03 at 16 28 51

@tombuildsstuff tombuildsstuff merged commit 00f3614 into master Jul 3, 2018
@tombuildsstuff tombuildsstuff deleted the b-vmss-1043 branch July 3, 2018 14:32
tombuildsstuff added a commit that referenced this pull request Jul 3, 2018
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug service/vmss Virtual Machine Scale Sets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"diffs didn't match during apply" when updating Scale Set
4 participants