-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VMSS: ensuring we always set the vhd_containers
field
#1411
Conversation
Do you mind throwing a test on this? I'd just like to see that extra bit of confirmation that the issue is fixed |
Looking into adding a test for this - since this is a set with a dynamic computed value (since the storage account name is being used, which has to be globally unique) - I don't think there's an easy way of computing this:
As such I'm going to suggest we merge this without a test specifically for this, since the Import tests are covering it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nested sets are a pain for testing, but I've personally used similar fixes. The import testing should cover this at least from the "no worse" standpoint. LGTM if the existing acceptance testing is happy. 👍
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Issue #1043 shows a Diff Mismatch where the
vhd_containers
field isn't set; this PR fixes that by ensuring the field is always set.Fixes #1043