Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default to AKS agent_pool_profile os_disk_size_gb property #2117

Merged
merged 4 commits into from
Oct 22, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Oct 19, 2018

As of yesterday the API now returns the real default (30) when 0 is supplied.

fixes #2114

@katbyte katbyte added this to the 1.17.1 milestone Oct 19, 2018
@ghost ghost added the size/XS label Oct 19, 2018
@katbyte katbyte requested a review from a team October 19, 2018 22:05
Copy link
Contributor

@metacpp metacpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, LGTM.

@katbyte
Copy link
Collaborator Author

katbyte commented Oct 19, 2018

Tests pass (except one unrelated failure)
screen shot 2018-10-19 at 15 44 52

Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katbyte LGTM

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM 👍

@@ -250,7 +250,7 @@ A `agent_pool_profile` block supports the following:
* `name` - (Required) Unique name of the Agent Pool Profile in the context of the Subscription and Resource Group. Changing this forces a new resource to be created.
* `count` - (Required) Number of Agents (VMs) in the Pool. Possible values must be in the range of 1 to 50 (inclusive). Defaults to `1`.
* `vm_size` - (Required) The size of each VM in the Agent Pool (e.g. `Standard_F1`). Changing this forces a new resource to be created.
* `os_disk_size_gb` - (Optional) The Agent Operating System disk size in GB. Changing this forces a new resource to be created.
* `os_disk_size_gb` - (Optional) The Agent Operating System disk size in GB. Changing this forces a new resource to be created. Defaults to `30`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this no longer defaults to 30 - so can we remove this?

@katbyte
Copy link
Collaborator Author

katbyte commented Oct 21, 2018

tests now pass:
screen shot 2018-10-21 at 16 09 30

@katbyte
Copy link
Collaborator Author

katbyte commented Oct 21, 2018

tests pass:
screen shot 2018-10-21 at 16 09 30

@katbyte katbyte merged commit bba6272 into master Oct 22, 2018
@katbyte katbyte deleted the b/aks-disksize branch October 22, 2018 15:56
katbyte added a commit that referenced this pull request Oct 22, 2018
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AKS cluster recreation triggered on apply since v1.17
4 participants