-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Data Sources: azurerm_lb
/ azurerm_lb_backend_address_pool
#2354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments inline
927fbc6
to
bf430ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from two inline comments LGTM @tombuildsstuff ✅
Tests pass: ``` $ acctests azurerm TestAccAzureRMDataSourceLoadBalancerBackEndAddressPool_basic === RUN TestAccAzureRMDataSourceLoadBalancerBackEndAddressPool_basic === PAUSE TestAccAzureRMDataSourceLoadBalancerBackEndAddressPool_basic === CONT TestAccAzureRMDataSourceLoadBalancerBackEndAddressPool_basic --- PASS: TestAccAzureRMDataSourceLoadBalancerBackEndAddressPool_basic (189.08s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 190.301s ```
Tests pass ``` $ acctests azurerm TestAccAzureRMDataSourceLoadBalancer_basic === RUN TestAccAzureRMDataSourceLoadBalancer_basic === PAUSE TestAccAzureRMDataSourceLoadBalancer_basic === CONT TestAccAzureRMDataSourceLoadBalancer_basic --- PASS: TestAccAzureRMDataSourceLoadBalancer_basic (178.79s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 180.681s ```
bf430ce
to
5ec0b4b
Compare
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Fixes #872