Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Sources: azurerm_lb / azurerm_lb_backend_address_pool #2354

Merged
merged 6 commits into from
Jan 11, 2019

Conversation

tombuildsstuff
Copy link
Contributor

Fixes #872

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tombuildsstuff,

Left some comments inline

azurerm/data_source_loadbalancer.go Outdated Show resolved Hide resolved
azurerm/data_source_loadbalancer.go Show resolved Hide resolved
azurerm/data_source_loadbalancer.go Outdated Show resolved Hide resolved
website/docs/d/loadbalancer.html.markdown Show resolved Hide resolved
website/docs/d/loadbalancer.html.markdown Show resolved Hide resolved
azurerm/data_source_loadbalancer_backend_address_pool.go Outdated Show resolved Hide resolved
azurerm/data_source_loadbalancer_backend_address_pool.go Outdated Show resolved Hide resolved
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

screenshot 2019-01-07 at 12 36 47

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from two inline comments LGTM @tombuildsstuff

azurerm/data_source_loadbalancer.go Show resolved Hide resolved
azurerm/data_source_loadbalancer.go Show resolved Hide resolved
Tests pass:
```
$ acctests azurerm TestAccAzureRMDataSourceLoadBalancerBackEndAddressPool_basic
=== RUN   TestAccAzureRMDataSourceLoadBalancerBackEndAddressPool_basic
=== PAUSE TestAccAzureRMDataSourceLoadBalancerBackEndAddressPool_basic
=== CONT  TestAccAzureRMDataSourceLoadBalancerBackEndAddressPool_basic
--- PASS: TestAccAzureRMDataSourceLoadBalancerBackEndAddressPool_basic (189.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	190.301s
```
Tests pass
```
$ acctests azurerm TestAccAzureRMDataSourceLoadBalancer_basic
=== RUN   TestAccAzureRMDataSourceLoadBalancer_basic
=== PAUSE TestAccAzureRMDataSourceLoadBalancer_basic
=== CONT  TestAccAzureRMDataSourceLoadBalancer_basic
--- PASS: TestAccAzureRMDataSourceLoadBalancer_basic (178.79s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       180.681s
```
@tombuildsstuff tombuildsstuff merged commit 2bdc65a into master Jan 11, 2019
@tombuildsstuff tombuildsstuff deleted the f/lb-data-sources branch January 11, 2019 14:04
tombuildsstuff added a commit that referenced this pull request Jan 11, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants