Application Insights Webtests

[AndyMoore]

fixes #1687

[AndyMoore]

this should now pass. I'd appreciate some input as I think it's probably a bit light on tests

Also there was some debate as to how this should be configured - I've gone with straight xml which is what Microsoft go with, and will add this to the documentation, but this could be abstracted away as well..

[katbyte]

Thank you for the PR @AndyMoore, this is looking pretty good!

Aside from the comments i've left inline a couple things:

• could we add a markdown file for documentation in the website folder?
• could we add some more tests? the _basic one sould only be the required properties, the bare minimum required to provision the resource. a _complete one can also be added and then an _update that has multiple steps goes from basic -> complete -> basic to check properties update.

thanks!

[katbyte]

A test is also failing with:

Test ended in panic.

------- Stdout: -------
=== RUN   TestAccAzureRMApplicationInsightsWebTests_basicWeb
=== PAUSE TestAccAzureRMApplicationInsightsWebTests_basicWeb
=== CONT  TestAccAzureRMApplicationInsightsWebTests_basicWeb

------- Stderr: -------
panic: Invalid address to set: []string{"configuration"}

This means you are trying to set that on read and it is not part of the schema.

[AndyMoore]

hi @katbyte thanks for the review. I've resolved the individual comments, and will add to the tests over the next few days

When I run the basicWeb test it passes locally:

?   	github.com/terraform-providers/terraform-provider-azurerm	[no test files]
=== RUN   TestAccAzureRMApplicationInsightsWebTests_basicWeb
=== PAUSE TestAccAzureRMApplicationInsightsWebTests_basicWeb
=== CONT  TestAccAzureRMApplicationInsightsWebTests_basicWeb
--- PASS: TestAccAzureRMApplicationInsightsWebTests_basicWeb (158.84s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	158.886s

[AndyMoore]

updated with tests as requested:

=== RUN   TestAccAzureRMApplicationInsightsWebTests_basic
=== PAUSE TestAccAzureRMApplicationInsightsWebTests_basic
=== RUN   TestAccAzureRMApplicationInsightsWebTests_complete
=== PAUSE TestAccAzureRMApplicationInsightsWebTests_complete
=== RUN   TestAccAzureRMApplicationInsightsWebTests_update
=== PAUSE TestAccAzureRMApplicationInsightsWebTests_update
=== RUN   TestAccAzureRMApplicationInsightsWebTests_requiresImport
--- SKIP: TestAccAzureRMApplicationInsightsWebTests_requiresImport (0.00s)
    resource_arm_application_insights_webtests_test.go:109: Skipping since resources aren't required to be imported
=== CONT  TestAccAzureRMApplicationInsightsWebTests_basic
=== CONT  TestAccAzureRMApplicationInsightsWebTests_update
=== CONT  TestAccAzureRMApplicationInsightsWebTests_complete
--- PASS: TestAccAzureRMApplicationInsightsWebTests_basic (153.51s)
--- PASS: TestAccAzureRMApplicationInsightsWebTests_complete (246.36s)
--- PASS: TestAccAzureRMApplicationInsightsWebTests_update (292.42s)
PASS

[tombuildsstuff]

hey @AndyMoore

Thanks for pushing those updates - taking a look through this is looking pretty good - if we can fix up the remaining comments this should otherwise be good to merge 👍

Thanks!

[AndyMoore]

=== RUN   TestAccAzureRMApplicationInsightsWebTests_basic
=== PAUSE TestAccAzureRMApplicationInsightsWebTests_basic
=== RUN   TestAccAzureRMApplicationInsightsWebTests_complete
=== PAUSE TestAccAzureRMApplicationInsightsWebTests_complete
=== RUN   TestAccAzureRMApplicationInsightsWebTests_update
=== PAUSE TestAccAzureRMApplicationInsightsWebTests_update
=== RUN   TestAccAzureRMApplicationInsightsWebTests_requiresImport
--- SKIP: TestAccAzureRMApplicationInsightsWebTests_requiresImport (0.00s)
    resource_arm_application_insights_webtests_test.go:105: Skipping since resources aren't required to be imported
=== CONT  TestAccAzureRMApplicationInsightsWebTests_basic
=== CONT  TestAccAzureRMApplicationInsightsWebTests_update
=== CONT  TestAccAzureRMApplicationInsightsWebTests_complete
--- PASS: TestAccAzureRMApplicationInsightsWebTests_basic (84.61s)
--- PASS: TestAccAzureRMApplicationInsightsWebTests_complete (85.89s)
--- PASS: TestAccAzureRMApplicationInsightsWebTests_update (207.05s)
PASS

tests still passing

will get the documents done asap

[katbyte]

@AndyMoore,

By default terraform ignores such schema errors. For our tests we turn on "strict" mode by running the tests with the following environment variable TF_SCHEMA_PANIC_ON_ERROR=1

I've left a comment on the offending line that is trying to set something that doesn't exist in the schema

[AndyMoore]

@katbyte removed

[katbyte]

Approved (forgot to click submit following):

Thanks for the updates @AndyMoore. Aside from renaming test_configurations to configurations this LGTM, hope you don't mind but I've pushed some changes to this affect 🙂

[AndyMoore]

thanks @katbyte

[ghost]

This has been released in version 1.29.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.29.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!