Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource 'azurerm_private_dns_mx_record' #4915

Merged
merged 3 commits into from
Nov 28, 2019

Conversation

phires
Copy link
Contributor

@phires phires commented Nov 19, 2019

Fixes #4914

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @phires, this looks really good. I just have 2 small nits around a potential nil and then checking that we import correctly after every test step

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr @phires,

I've left some additional comments inline

azurerm/resource_arm_private_dns_mx_record.go Outdated Show resolved Hide resolved
azurerm/resource_arm_private_dns_mx_record.go Show resolved Hide resolved
website/docs/r/private_dns_mx_record.html.markdown Outdated Show resolved Hide resolved
website/docs/r/private_dns_mx_record.html.markdown Outdated Show resolved Hide resolved
azurerm/resource_arm_private_dns_mx_record_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_private_dns_mx_record_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_private_dns_mx_record_test.go Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff modified the milestone: v1.38.0 Nov 26, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revisions @phires, LGTM now! 👍

@katbyte katbyte added this to the v1.38.0 milestone Nov 28, 2019
@katbyte katbyte merged commit b703400 into hashicorp:master Nov 28, 2019
katbyte added a commit that referenced this pull request Nov 28, 2019
@phires phires deleted the private-dns-mx branch November 29, 2019 15:51
@ghost
Copy link

ghost commented Dec 7, 2019

This has been released in version 1.38.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.38.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 29, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Dec 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Private DNS MX records
4 participants