Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster - add managed_cluster_identity support #5168

Merged
merged 6 commits into from
Dec 18, 2019

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Dec 14, 2019

Address #4506

@mbfrahry mbfrahry changed the title azurerm_kubernetes_cluster - add managed_cluster_identity_support azurerm_kubernetes_cluster - add managed_cluster_identity support Dec 14, 2019
@mbfrahry mbfrahry added this to the v1.40.0 milestone Dec 14, 2019
Copy link
Contributor

@tracypholmes tracypholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the exception of the docs change I commented on, everything else LGTM 😄

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a couple minor comments LGTM 👍

Comment on lines 829 to 831
managedClusterIdentityRaw := d.Get("managed_cluster_identity").([]interface{})
managedClusterIdentity := expandKubernetesClusterManagedClusterIdentity(managedClusterIdentityRaw)
existing.Identity = managedClusterIdentity
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor but this could be

		existing.Identity = expandKubernetesClusterManagedClusterIdentity(d.Get("managed_cluster_identity")) 

if the expand sig is changed

Comment on lines 1456 to 1460
managedClusterIdentity := &containerservice.ManagedClusterIdentity{
Type: containerservice.ResourceIdentityType(val["type"].(string)),
}

return managedClusterIdentity
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also be

return &containerservice.ManagedClusterIdentity{
		Type: containerservice.ResourceIdentityType(val["type"].(string)),
	}

as there is no value is assigning it to a var

return nil
}

val := input[0].(map[string]interface{})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would values make more sense?

Suggested change
val := input[0].(map[string]interface{})
values := input[0].(map[string]interface{})

azurerm/resource_arm_kubernetes_cluster.go Show resolved Hide resolved
@katbyte katbyte merged commit dd2ccff into master Dec 18, 2019
@katbyte katbyte deleted the f-kubernetes-msi branch December 18, 2019 20:15
katbyte added a commit that referenced this pull request Dec 18, 2019
@ghost
Copy link

ghost commented Jan 8, 2020

This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.40.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants