Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip cloud sync when endpoints are not deployed. #1017

Merged
merged 13 commits into from
Jul 14, 2023
Merged

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Jul 7, 2023

No description provided.

@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for terramate-io-docs ready!

Name Link
🔨 Latest commit a8cb9cb
🔍 Latest deploy log https://app.netlify.com/sites/terramate-io-docs/deploys/64aff8dc7e6a9b00086fb420
😎 Deploy Preview https://deploy-preview-1017--terramate-io-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

metric: time/op
ListFiles-2: old 180µs ± 7%: new 180µs ±10%: delta: 0.00%
Generate-2: old 3.78s ± 4%: new 3.87s ± 4%: delta: 2.63%
GenerateRegex-2: old 2.32s ± 5%: new 2.39s ± 5%: delta: 2.85%
TokensForExpressionComplex-2: old 2.23ms ± 6%: new 2.21ms ± 6%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-2: old 1.67µs ± 6%: new 1.68µs ± 7%: delta: 0.00%
TokensForExpressionStringWith100Newlines-2: old 52.5µs ± 8%: new 53.1µs ± 4%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-2: old 2.52ms ± 8%: new 2.60ms ± 3%: delta: 3.15%
TokensForExpression-2: old 2.24ms ± 6%: new 2.17ms ± 4%: delta: -3.47%
PartialEvalComplex-2: old 717µs ± 5%: new 690µs ±10%: delta: -3.73%
PartialEvalSmallString-2: old 6.18µs ± 5%: new 6.41µs ± 7%: delta: 3.77%
PartialEvalHugeString-2: old 3.05ms ± 3%: new 3.13ms ± 4%: delta: 2.72%
PartialEvalHugeInterpolatedString-2: old 8.11ms ± 4%: new 8.43ms ± 7%: delta: 3.93%
PartialEvalObject-2: old 35.5µs ± 6%: new 35.9µs ± 6%: delta: 0.00%
metric: alloc/op
ListFiles-2: old 99.5kB ± 0%: new 99.5kB ± 0%: delta: 0.00%
Generate-2: old 2.05GB ± 0%: new 2.05GB ± 0%: delta: 0.00%
GenerateRegex-2: old 806MB ± 0%: new 806MB ± 0%: delta: 0.00%
TokensForExpressionComplex-2: old 411kB ± 0%: new 411kB ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-2: old 592B ± 0%: new 592B ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-2: old 14.0kB ± 0%: new 14.0kB ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-2: old 400kB ± 0%: new 400kB ± 0%: delta: 0.00%
TokensForExpression-2: old 411kB ± 0%: new 411kB ± 0%: delta: -0.01%
PartialEvalComplex-2: old 344kB ± 0%: new 344kB ± 0%: delta: 0.00%
PartialEvalSmallString-2: old 1.74kB ± 0%: new 1.74kB ± 0%: delta: 0.00%
PartialEvalHugeString-2: old 166kB ± 0%: new 166kB ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-2: old 4.38MB ± 0%: new 4.38MB ± 0%: delta: -0.00%
PartialEvalObject-2: old 20.4kB ± 0%: new 20.4kB ± 0%: delta: 0.00%
metric: allocs/op
ListFiles-2: old 474 ± 0%: new 474 ± 0%: delta: 0.00%
Generate-2: old 22.7M ± 0%: new 22.7M ± 0%: delta: 0.00%
GenerateRegex-2: old 16.4M ± 0%: new 16.4M ± 0%: delta: 0.00%
TokensForExpressionComplex-2: old 4.85k ± 0%: new 4.85k ± 0%: delta: -0.01%
TokensForExpressionPlainStringNoNewline-2: old 21.0 ± 0%: new 21.0 ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-2: old 328 ± 0%: new 328 ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-2: old 3.19k ± 0%: new 3.19k ± 0%: delta: 0.00%
TokensForExpression-2: old 4.85k ± 0%: new 4.85k ± 0%: delta: -0.01%
PartialEvalComplex-2: old 2.61k ± 0%: new 2.61k ± 0%: delta: 0.00%
PartialEvalSmallString-2: old 23.0 ± 0%: new 23.0 ± 0%: delta: 0.00%
PartialEvalHugeString-2: old 35.0 ± 0%: new 35.0 ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-2: old 23.1k ± 0%: new 23.1k ± 0%: delta: 0.00%
PartialEvalObject-2: old 125 ± 0%: new 125 ± 0%: delta: 0.00%

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 37.70% and project coverage change: -0.17 ⚠️

Comparison is base (0c765e2) 65.64% compared to head (a8cb9cb) 65.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1017      +/-   ##
==========================================
- Coverage   65.64%   65.47%   -0.17%     
==========================================
  Files          94       94              
  Lines       14877    14918      +41     
==========================================
+ Hits         9766     9768       +2     
- Misses       4744     4781      +37     
- Partials      367      369       +2     
Flag Coverage Δ
tests 65.47% <37.70%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/terramate/cli/cli.go 0.00% <0.00%> (ø)
cmd/terramate/cli/cloud.go 0.00% <0.00%> (ø)
test/sandbox/sandbox.go 85.46% <ø> (-0.05%) ⬇️
cloud/cloud.go 46.72% <16.66%> (-3.78%) ⬇️
cloud/testserver/handlers.go 72.78% <100.00%> (+2.86%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

zied-elouaer
zied-elouaer previously approved these changes Jul 7, 2023
Copy link

@zied-elouaer zied-elouaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@i4ki i4ki marked this pull request as ready for review July 12, 2023 18:16
@i4ki i4ki requested a review from a team as a code owner July 12, 2023 18:16
Copy link
Contributor

@MordecaiMalignatus MordecaiMalignatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to steal some of your test fixture patterns, they're elegant.

@i4ki i4ki merged commit da5e09e into main Jul 14, 2023
@i4ki i4ki deleted the i4k-skip-deployment branch July 14, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants