Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send pull request HEAD sha instead of current HEAD. #1089

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Aug 7, 2023

Reason for This Change

When using the --cloud-sync-deployment, the review_request field was being populated with the current HEAD sha instead of the associated pull request HEAD sha.

@i4ki i4ki requested a review from a team as a code owner August 7, 2023 13:11
@netlify
Copy link

netlify bot commented Aug 7, 2023

Deploy Preview for terramate-io-docs canceled.

Name Link
🔨 Latest commit d7d5141
🔍 Latest deploy log https://app.netlify.com/sites/terramate-io-docs/deploys/64d0eda0916e590008c0b199

@i4ki i4ki marked this pull request as draft August 7, 2023 13:14
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (862ddb4) 64.80% compared to head (d7d5141) 64.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1089      +/-   ##
==========================================
- Coverage   64.80%   64.79%   -0.02%     
==========================================
  Files          98       98              
  Lines       15473    15476       +3     
==========================================
- Hits        10028    10027       -1     
- Misses       5052     5056       +4     
  Partials      393      393              
Flag Coverage Δ
tests 64.79% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cmd/terramate/cli/cloud.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Aug 7, 2023


@i4ki i4ki marked this pull request as ready for review August 7, 2023 18:06
mariux
mariux previously approved these changes Aug 7, 2023
Copy link
Contributor

@mariux mariux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@i4ki i4ki added this pull request to the merge queue Aug 7, 2023
@github-merge-queue github-merge-queue bot dismissed mariux’s stale review August 7, 2023 18:24

The merge-base changed after approval.

Merged via the queue into main with commit 30fe316 Aug 7, 2023
16 checks passed
@i4ki i4ki deleted the i4k-fix-review-request-sha2 branch August 7, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants