Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tmc): introduce uimode in the cli for enhanced cloud fail cases. #1150

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Sep 19, 2023

The Human x Automation UI modes were introduced for different error handling depending on where is the execution.

@netlify
Copy link

netlify bot commented Sep 19, 2023

Deploy Preview for terramate-io-docs canceled.

Name Link
🔨 Latest commit 8fbe2f8
🔍 Latest deploy log https://app.netlify.com/sites/terramate-io-docs/deploys/650be81b0f84df00079411ab

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 22.83% and project coverage change: -0.10% ⚠️

Comparison is base (0a33ff1) 63.45% compared to head (8fbe2f8) 63.35%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1150      +/-   ##
==========================================
- Coverage   63.45%   63.35%   -0.10%     
==========================================
  Files         102      102              
  Lines       16132    16173      +41     
==========================================
+ Hits        10236    10246      +10     
- Misses       5479     5510      +31     
  Partials      417      417              
Flag Coverage Δ
tests 63.35% <22.83%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cmd/terramate/cli/cli.go 0.00% <0.00%> (ø)
cmd/terramate/cli/cloud.go 0.00% <0.00%> (ø)
cmd/terramate/cli/cloud_credential_github.go 0.00% <0.00%> (ø)
cmd/terramate/cli/cloud_credential_google.go 0.00% <0.00%> (ø)
cmd/terramate/cli/cloud_sync_deployment.go 0.00% <0.00%> (ø)
cmd/terramate/cli/cloud_sync_drift.go 0.00% <0.00%> (ø)
cmd/terramate/cli/run.go 0.00% <0.00%> (ø)
cloud/types.go 40.32% <75.00%> (-1.00%) ⬇️
cloud/testserver/handlers.go 66.26% <100.00%> (+0.94%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Sep 19, 2023

metric: time/op
ListFiles-2: old 197µs ± 6%: new 199µs ± 4%: delta: 0.00%
Generate-2: old 4.38s ± 3%: new 4.56s ± 3%: delta: 4.17%
GenerateRegex-2: old 2.78s ± 3%: new 2.97s ± 6%: delta: 6.68%
TokensForExpressionComplex-2: old 2.35ms ± 4%: new 2.47ms ± 4%: delta: 4.92%
TokensForExpressionPlainStringNoNewline-2: old 1.78µs ± 4%: new 1.81µs ± 4%: delta: 2.00%
TokensForExpressionStringWith100Newlines-2: old 60.0µs ± 4%: new 60.9µs ± 4%: delta: 1.50%
TokensForExpressionObjectWith100KeysWithNumberValues-2: old 2.65ms ± 4%: new 2.66ms ± 3%: delta: 0.00%
TokensForExpression-2: old 2.40ms ± 5%: new 2.40ms ± 4%: delta: 0.00%
PartialEvalComplex-2: old 819µs ± 4%: new 807µs ± 4%: delta: 0.00%
PartialEvalSmallString-2: old 7.02µs ± 3%: new 7.02µs ± 8%: delta: 0.00%
PartialEvalHugeString-2: old 3.69ms ± 3%: new 3.74ms ± 4%: delta: 1.33%
PartialEvalHugeInterpolatedString-2: old 9.38ms ± 3%: new 9.83ms ± 3%: delta: 4.77%
PartialEvalObject-2: old 41.7µs ± 4%: new 43.6µs ± 4%: delta: 4.48%
metric: alloc/op
ListFiles-2: old 99.4kB ± 0%: new 99.4kB ± 0%: delta: 0.00%
Generate-2: old 2.05GB ± 0%: new 2.05GB ± 0%: delta: 0.00%
GenerateRegex-2: old 806MB ± 0%: new 806MB ± 0%: delta: 0.00%
TokensForExpressionComplex-2: old 411kB ± 0%: new 411kB ± 0%: delta: 0.02%
TokensForExpressionPlainStringNoNewline-2: old 592B ± 0%: new 592B ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-2: old 14.0kB ± 0%: new 14.0kB ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-2: old 400kB ± 0%: new 400kB ± 0%: delta: 0.00%
TokensForExpression-2: old 411kB ± 0%: new 411kB ± 0%: delta: 0.00%
PartialEvalComplex-2: old 344kB ± 0%: new 344kB ± 0%: delta: 0.00%
PartialEvalSmallString-2: old 1.74kB ± 0%: new 1.74kB ± 0%: delta: 0.00%
PartialEvalHugeString-2: old 166kB ± 0%: new 166kB ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-2: old 4.38MB ± 0%: new 4.38MB ± 0%: delta: 0.00%
PartialEvalObject-2: old 20.4kB ± 0%: new 20.4kB ± 0%: delta: 0.00%
metric: allocs/op
ListFiles-2: old 474 ± 0%: new 474 ± 0%: delta: 0.00%
Generate-2: old 22.7M ± 0%: new 22.7M ± 0%: delta: 0.00%
GenerateRegex-2: old 16.4M ± 0%: new 16.4M ± 0%: delta: 0.00%
TokensForExpressionComplex-2: old 4.85k ± 0%: new 4.85k ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-2: old 21.0 ± 0%: new 21.0 ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-2: old 328 ± 0%: new 328 ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-2: old 3.19k ± 0%: new 3.19k ± 0%: delta: 0.00%
TokensForExpression-2: old 4.85k ± 0%: new 4.85k ± 0%: delta: 0.00%
PartialEvalComplex-2: old 2.61k ± 0%: new 2.61k ± 0%: delta: 0.00%
PartialEvalSmallString-2: old 23.0 ± 0%: new 23.0 ± 0%: delta: 0.00%
PartialEvalHugeString-2: old 35.0 ± 0%: new 35.0 ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-2: old 23.1k ± 0%: new 23.1k ± 0%: delta: 0.00%
PartialEvalObject-2: old 125 ± 0%: new 125 ± 0%: delta: 0.00%

@i4ki i4ki force-pushed the i4k-cloud-sync-err-handling branch 5 times, most recently from 6306b29 to 747e9be Compare September 20, 2023 00:18
@i4ki i4ki marked this pull request as ready for review September 20, 2023 00:19
@i4ki i4ki requested a review from a team as a code owner September 20, 2023 00:19
@i4ki i4ki force-pushed the i4k-cloud-sync-err-handling branch 2 times, most recently from 20b0cbf to f034e8d Compare September 20, 2023 07:25
@i4ki i4ki marked this pull request as draft September 20, 2023 08:32
@i4ki i4ki force-pushed the i4k-cloud-sync-err-handling branch from f034e8d to 6fdc0a4 Compare September 20, 2023 20:49
The Human x Automation UI modes were introduced for different error
handling depending on where is the execution.

Signed-off-by: Tiago Natel <t.nateldemoura@gmail.com>
@i4ki i4ki force-pushed the i4k-cloud-sync-err-handling branch from 6fdc0a4 to 8fbe2f8 Compare September 21, 2023 06:52
@i4ki i4ki marked this pull request as ready for review September 21, 2023 06:52
Copy link
Contributor

@MordecaiMalignatus MordecaiMalignatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderfully thorough testing 👍

@i4ki i4ki added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit f449935 Sep 21, 2023
16 checks passed
@i4ki i4ki deleted the i4k-cloud-sync-err-handling branch September 21, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants