Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tmc): omit optional fields of the stack object #1153

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Sep 21, 2023

No description provided.

Signed-off-by: Tiago Natel <t.nateldemoura@gmail.com>
@i4ki i4ki requested a review from a team as a code owner September 21, 2023 14:09
@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for terramate-io-docs canceled.

Name Link
🔨 Latest commit 111c8ff
🔍 Latest deploy log https://app.netlify.com/sites/terramate-io-docs/deploys/650c4ea1cce8fc00085d0d9c

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (3c25c99) 63.30% compared to head (111c8ff) 63.29%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1153      +/-   ##
==========================================
- Coverage   63.30%   63.29%   -0.02%     
==========================================
  Files         102      102              
  Lines       16188    16188              
==========================================
- Hits        10248    10246       -2     
- Misses       5522     5524       +2     
  Partials      418      418              
Flag Coverage Δ
tests 63.29% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cloud/types.go 38.75% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@i4ki i4ki added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit bd08f6d Sep 21, 2023
16 checks passed
@i4ki i4ki deleted the i4k-fix-omitempty branch September 21, 2023 14:27
@github-actions
Copy link

metric: time/op
ListFiles-2: old 183µs ± 6%: new 179µs ± 4%: delta: -2.15%
Generate-2: old 3.91s ± 4%: new 4.05s ± 3%: delta: 3.55%
GenerateRegex-2: old 2.46s ± 5%: new 2.46s ± 4%: delta: 0.00%
TokensForExpressionComplex-2: old 2.25ms ± 2%: new 2.27ms ± 4%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-2: old 1.73µs ± 3%: new 1.70µs ± 3%: delta: -1.77%
TokensForExpressionStringWith100Newlines-2: old 55.8µs ± 3%: new 54.3µs ± 3%: delta: -2.64%
TokensForExpressionObjectWith100KeysWithNumberValues-2: old 2.62ms ± 3%: new 2.58ms ± 4%: delta: -1.41%
TokensForExpression-2: old 2.29ms ± 3%: new 2.26ms ± 4%: delta: -1.47%
PartialEvalComplex-2: old 727µs ± 4%: new 726µs ± 7%: delta: 0.00%
PartialEvalSmallString-2: old 6.49µs ± 4%: new 6.42µs ± 3%: delta: 0.00%
PartialEvalHugeString-2: old 3.13ms ± 2%: new 3.11ms ± 2%: delta: 0.00%
PartialEvalHugeInterpolatedString-2: old 8.49ms ± 4%: new 8.51ms ± 4%: delta: 0.00%
PartialEvalObject-2: old 36.4µs ± 4%: new 37.1µs ± 4%: delta: 1.96%
metric: alloc/op
ListFiles-2: old 99.4kB ± 0%: new 99.4kB ± 0%: delta: 0.00%
Generate-2: old 2.05GB ± 0%: new 2.05GB ± 0%: delta: 0.00%
GenerateRegex-2: old 805MB ± 0%: new 806MB ± 0%: delta: 0.02%
TokensForExpressionComplex-2: old 411kB ± 0%: new 411kB ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-2: old 592B ± 0%: new 592B ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-2: old 14.0kB ± 0%: new 14.0kB ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-2: old 400kB ± 0%: new 400kB ± 0%: delta: 0.00%
TokensForExpression-2: old 411kB ± 0%: new 411kB ± 0%: delta: 0.00%
PartialEvalComplex-2: old 344kB ± 0%: new 344kB ± 0%: delta: 0.00%
PartialEvalSmallString-2: old 1.74kB ± 0%: new 1.74kB ± 0%: delta: 0.00%
PartialEvalHugeString-2: old 166kB ± 0%: new 166kB ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-2: old 4.38MB ± 0%: new 4.38MB ± 0%: delta: 0.00%
PartialEvalObject-2: old 20.4kB ± 0%: new 20.4kB ± 0%: delta: 0.00%
metric: allocs/op
ListFiles-2: old 474 ± 0%: new 474 ± 0%: delta: 0.00%
Generate-2: old 22.7M ± 0%: new 22.7M ± 0%: delta: 0.00%
GenerateRegex-2: old 16.4M ± 0%: new 16.4M ± 0%: delta: 0.00%
TokensForExpressionComplex-2: old 4.85k ± 0%: new 4.85k ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-2: old 21.0 ± 0%: new 21.0 ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-2: old 328 ± 0%: new 328 ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-2: old 3.19k ± 0%: new 3.19k ± 0%: delta: 0.00%
TokensForExpression-2: old 4.85k ± 0%: new 4.85k ± 0%: delta: 0.00%
PartialEvalComplex-2: old 2.61k ± 0%: new 2.61k ± 0%: delta: 0.00%
PartialEvalSmallString-2: old 23.0 ± 0%: new 23.0 ± 0%: delta: 0.00%
PartialEvalHugeString-2: old 35.0 ± 0%: new 35.0 ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-2: old 23.1k ± 0%: new 23.1k ± 0%: delta: 0.00%
PartialEvalObject-2: old 125 ± 0%: new 125 ± 0%: delta: 0.00%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants