Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tight Coupling: Convergence Summary should not specify norm type #1115

Closed
albeanth opened this issue Jan 23, 2023 · 0 comments · Fixed by #1172
Closed

Tight Coupling: Convergence Summary should not specify norm type #1115

albeanth opened this issue Jan 23, 2023 · 0 comments · Fixed by #1172
Assignees
@albeanth
Labels
cleanup Code/comment cleanup: Low Priority

Comments

@albeanth
Copy link
Member

armi/armi/bookkeeping/report/reportingUtils.py

Line 241 in b86547b

runLog.info("Tight Coupling Convergence Summary: Norm Type = Inf")

The norm type for tight coupling convergence is not always an infinity norm and the summary-table should not state so.
@albeanth albeanth added the cleanup Code/comment cleanup: Low Priority label Jan 23, 2023
@albeanth albeanth self-assigned this Jan 23, 2023
albeanth added a commit to albeanth/armi that referenced this issue Feb 8, 2023
@albeanth
rm wrong norm type from TC summary table
5232f93 
Closes terrapower#1115
albeanth added a commit to albeanth/armi that referenced this issue Feb 9, 2023
@albeanth
rm wrong norm type from TC summary table
15d3246 
Closes terrapower#1115
@albeanth albeanth mentioned this issue Feb 9, 2023
Merged
7 tasks
opotowsky pushed a commit that referenced this issue Feb 16, 2023
@albeanth
Edit tight coupling runLogs + refactor tight coupling unit tests (#…
7a91be9 
…1172)

Closes #1115
Closes #1162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albeanth albeanth

Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Edit tight coupling runLogs + refactor tight coupling unit tests albeanth/armi
1 participant
@albeanth