Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening up the disable snapshot interfaces list #1148

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Conversation

john-science
Copy link
Member

Description

There was a hard-coded list in snapshots.py that recently became really important. People might need to change this list. By preference, I believe this is not so common a need that it should be done as a Setting; it would be better as a class attribute. Even without this request, this list is better as a class attribute, because we don't like hard-coding data.

NOTE: Based on a discussion yesterday with @keckler, I am finally removing our rule against using the super() method. I have not found this rule to be productive or helpful. It's high past time.


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@john-science john-science added cleanup Code/comment cleanup: Low Priority feature request Smaller user request labels Feb 3, 2023
@john-science john-science linked an issue Feb 3, 2023 that may be closed by this pull request
@john-science john-science merged commit 7ccf04d into main Feb 9, 2023
@john-science john-science deleted the snapshots_disable branch February 9, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority feature request Smaller user request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hardcoded interface disabling in snapshots.py
3 participants