Opening up the disable snapshot interfaces list #1148
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a hard-coded list in
snapshots.py
that recently became really important. People might need to change this list. By preference, I believe this is not so common a need that it should be done as aSetting
; it would be better as a class attribute. Even without this request, this list is better as a class attribute, because we don't like hard-coding data.NOTE: Based on a discussion yesterday with @keckler, I am finally removing our rule against using the
super()
method. I have not found this rule to be productive or helpful. It's high past time.Checklist
doc/release/0.X.rst
) are up-to-date with any bug fixes or new features.doc
folder.setup.py
.