Add Thermal Expansion/Contraction Methodology to Docs #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add derivation for how thermal expansion is handled in ARMI. 2. Update Material.linearExpansionFactor docstring
|
@john-science @alexhjames @drewj-usnctech @sombrereau @onufer @jakehader just a heads up. |
keckler
approved these changes
Mar 8, 2023
opotowsky
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
Sorry for the delay! This looks great and is easy to follow.
I don't think I noticed any errors that Chris didn't already point out. Also, I agree you don't need the extra line of math getting from pct to frac.
We need a lot more of this, so thanks for leading by example!
|
I'm good with the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the first of a series of PRs that will add documentation for radial and axial expansion methodologies in ARMI.
This PR adds the methodology used in ARMI to perform linear expansion by creating a new page/section within
doc/userand cleans up the docstring forMaterial.linearExpansionFactor.Cross linking #935 as it is related.
Reviewers, please pull the feature branch and compile the ARMI docs to confirm that they build correctly. There are no new dependencies, but it will be good to confirm.
Checklist
Tests have been added/updated to verify that the new/changed code works.doc/release/0.X.rst) are up-to-date with any bug fixes or new features.docfolder.setup.py.