Define copyOutput on ExecutionOptions #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially defined only on globalFlux options.
albeanth
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Thanks, @mgjarrett! Just one comment, since you replace this PR with #1218 in the release notes, please link PR #1218 in the description of this PR so we have a reference of this PR being a fix for #1218. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The attribute was initially defined one level below, on GlobalFluxOptions, in #1218
With
_collectInputsAndOutputsdefined on the base classExecutionOptions,copyOutputalso needed to be moved up.Checklist
doc/release/0.X.rst) are up-to-date with any bug fixes or new features.docfolder.setup.py.