Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file names to copy for snapshotRequest #1294

Merged
merged 14 commits into from
Jun 13, 2023

Conversation

mgjarrett
Copy link
Contributor

@mgjarrett mgjarrett commented Jun 8, 2023

Description

The snapshotInterface needed an interactCoupled method. Also, the file names for latticePhysics and neutronics kernel files to be copied needed to be updated.


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@mgjarrett mgjarrett requested a review from albeanth June 8, 2023 23:02
@albeanth albeanth marked this pull request as ready for review June 13, 2023 16:54
doc/release/0.2.rst Outdated Show resolved Hide resolved
@john-science john-science added the feature request Smaller user request label Jun 13, 2023
@john-science
Copy link
Member

I hope to see more use of unittest.mock in ARMI!

And I'm surprised to see this is our first use of mock.patch in ARMI!

@albeanth albeanth merged commit 27ecb49 into terrapower:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Smaller user request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants