Update reactivity coefficient parameters #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treat tuples and ranges as numpy arrays also.
albeanth
reviewed
Jul 25, 2023
albeanth
approved these changes
Jul 28, 2023
jakehader
reviewed
Jul 30, 2023
jakehader
reviewed
Jul 30, 2023
|
So, quick question. These parameters need to be in ARMI and not a downstream reactivity coeffs plugin/repo? |
|
And one the great debates (well, to me lol) rages on! I'm of the opinion that these (amongst, many many others) should be moved downstream. I recognize the other arguments for keeping these sorts of things on ARMI, but I currently think they should be moved downstream. Just my two cents. |
|
Yeah, these parameters could definitely be moved to a downstream plugin, but I was just trying to tread lightly here. The PR was mostly about fixing minor issues with default values or locations for a few parameters. I only added one new reactivity coefficients parameter, which can be migrated downstream with the others if/when that happens. |
drewj-usnctech
added a commit
to drewj-usnctech/armi
that referenced
this pull request
Aug 24, 2023
…id-refactor-pre-1278 * terrapower/main: Move max assembly number out of global scope (terrapower#1383) Ensuring we throw an error on bad YAML files (terrapower#1358) Removing unused settings (terrapower#1393) Fixing some miscellaneous TODOs (terrapower#1392) Removing global plugin flags (terrapower#1388) Update reactivity coefficient parameters (terrapower#1355) Fixing ruff formatting of doc gallery examples (terrapower#1389) Fixing broken link (terrapower#1390) Removing unreachable code block (terrapower#1391) Removing unnecessary f-strings (terrapower#1387) Updating documentation dependencies for Python 3.11 (terrapower#1378) Adding a little code coverage to the CLIs (terrapower#1371) Remove coveragepy-lcov dependency during CI. (terrapower#1382) Reconnect logger after disconnecting in test. (terrapower#1381) Add Python 3.11 to GH Actions (terrapower#1341) Removing global variable from runLog.py (terrapower#1370) Moving the First-Time Contributors guide to the docs (terrapower#1368)
mgjarrett
added a commit
to mgjarrett/armi
that referenced
this pull request
Aug 24, 2023
* Update rxcoeff parameter attributes. * Add thermal hydraulics parameter category. * Add rxFuelAxialExpansionPerPercent parameter.
drewj-usnctech
added a commit
to drewj-usnctech/armi
that referenced
this pull request
Sep 6, 2023
…t-mod-empty-validation * terrapower/main: (23 commits) Allowing users to set powerDensity instead of power (terrapower#1395) Fix assemNum parameter for uniform mesh reactor. (terrapower#1398) Update to black v22.6.0 (terrapower#1396) Fixing gallery example for new working Grids (terrapower#1394) Refactor armi.reactor.grids to wider submodule; Grids as ABC (terrapower#1373) Make SFP a child of reactor. (terrapower#1349) Move max assembly number out of global scope (terrapower#1383) Ensuring we throw an error on bad YAML files (terrapower#1358) Removing unused settings (terrapower#1393) Fixing some miscellaneous TODOs (terrapower#1392) Removing global plugin flags (terrapower#1388) Update reactivity coefficient parameters (terrapower#1355) Fixing ruff formatting of doc gallery examples (terrapower#1389) Fixing broken link (terrapower#1390) Removing unreachable code block (terrapower#1391) Removing unnecessary f-strings (terrapower#1387) Updating documentation dependencies for Python 3.11 (terrapower#1378) Adding a little code coverage to the CLIs (terrapower#1371) Remove coveragepy-lcov dependency during CI. (terrapower#1382) Reconnect logger after disconnecting in test. (terrapower#1381) ...
mgjarrett
added a commit
to mgjarrett/armi
that referenced
this pull request
Oct 25, 2023
* Update rxcoeff parameter attributes. * Add thermal hydraulics parameter category. * Add rxFuelAxialExpansionPerPercent parameter.
opotowsky
pushed a commit
that referenced
this pull request
Oct 26, 2023
* Update rxcoeff parameter attributes. * Add thermal hydraulics parameter category. * Add rxFuelAxialExpansionPerPercent parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
Update the parameter definition for some reactivity coefficient parameters to get the correct uniform mesh mapping behavior (change from
ParamLocation.AVERAGEtoParamLocation.VOLUME_INTEGRATED).Also changed some parameter defaults (
Nonefor list/array-like,0.0for scalar floats).Simplified the logic for getting parameter values to be mapped in the uniform mesh converter.
Why is the change being made?
Certain parameters were not being mapped correctly because they were listed with the wrong
ParamLocationtag.Checklist
doc/release/0.X.rst) are up-to-date with any important changes.docfolder.setup.py.