-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove coveragepy-lcov dependency during CI. #1382
Conversation
coveragepy-lcov is incompatible with coverage 7.0.0 and in fact is totally unnecessary now that pytest can write lcov format files directly. This switches pytest to write lcov directly. Now coverage should work in CI on python 3.11 Fixes #1377
I LOVE removing dependencies. Awesome. And I note that the "coverage" step on GH Actions has already passed for this PR. You rock, man. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things that I can't comment inline:
- In
.github/workflows/coverage.yaml
Can you update python 3.10 to 3.11? - In
setup.py
, you'll note a silly little python-version-specific coverage version update I made to get the first py311 PR merged. I think given this GH action cleanup we can revert that update, and just remove the coverage version pin altogether.
Requested in review.
ok done. Part of me wonders if coverage belongs in the install_requires section at all, since it's not used at runtime, but I'm happy to clean out those pins for now. |
I turns out Line 41 in 06bf1f1
Line 66 in 06bf1f1
Line 353 in 06bf1f1
And when I suggested we could pull that out because it's not used, I believe @jakehader lobbied quite hard that this was used and shouldn't be removed. (I might be mis-remembering WHO lobbied so hard, but someone.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for digging into this!
Actually this might have a viable use case and it's been on my ToDo backburner for a few months. So I'd also lobby to keep it until we know it's not useful! |
…id-refactor-pre-1278 * terrapower/main: Move max assembly number out of global scope (terrapower#1383) Ensuring we throw an error on bad YAML files (terrapower#1358) Removing unused settings (terrapower#1393) Fixing some miscellaneous TODOs (terrapower#1392) Removing global plugin flags (terrapower#1388) Update reactivity coefficient parameters (terrapower#1355) Fixing ruff formatting of doc gallery examples (terrapower#1389) Fixing broken link (terrapower#1390) Removing unreachable code block (terrapower#1391) Removing unnecessary f-strings (terrapower#1387) Updating documentation dependencies for Python 3.11 (terrapower#1378) Adding a little code coverage to the CLIs (terrapower#1371) Remove coveragepy-lcov dependency during CI. (terrapower#1382) Reconnect logger after disconnecting in test. (terrapower#1381) Add Python 3.11 to GH Actions (terrapower#1341) Removing global variable from runLog.py (terrapower#1370) Moving the First-Time Contributors guide to the docs (terrapower#1368)
…t-mod-empty-validation * terrapower/main: (23 commits) Allowing users to set powerDensity instead of power (terrapower#1395) Fix assemNum parameter for uniform mesh reactor. (terrapower#1398) Update to black v22.6.0 (terrapower#1396) Fixing gallery example for new working Grids (terrapower#1394) Refactor armi.reactor.grids to wider submodule; Grids as ABC (terrapower#1373) Make SFP a child of reactor. (terrapower#1349) Move max assembly number out of global scope (terrapower#1383) Ensuring we throw an error on bad YAML files (terrapower#1358) Removing unused settings (terrapower#1393) Fixing some miscellaneous TODOs (terrapower#1392) Removing global plugin flags (terrapower#1388) Update reactivity coefficient parameters (terrapower#1355) Fixing ruff formatting of doc gallery examples (terrapower#1389) Fixing broken link (terrapower#1390) Removing unreachable code block (terrapower#1391) Removing unnecessary f-strings (terrapower#1387) Updating documentation dependencies for Python 3.11 (terrapower#1378) Adding a little code coverage to the CLIs (terrapower#1371) Remove coveragepy-lcov dependency during CI. (terrapower#1382) Reconnect logger after disconnecting in test. (terrapower#1381) ...
What is the change?
coveragepy-lcov is incompatible with coverage 7.0.0 and in fact is totally unnecessary now that pytest can write lcov format files directly. This switches pytest to write lcov directly. Now coverage should work in CI on python 3.11.
Fixes #1377
I have not fully tested this but tested the components. Will need to let CI run to see if it fully works I think.
Why is the change being made?
We want coverage on python 3.11
Checklist
doc/release/0.X.rst
) are up-to-date with any important changes.doc
folder.setup.py
.