Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
For some reason, the
Flag
s defined by eachPlugin
were defined in the global scope. Here I moved that inside theApp
.Why is the change being made?
The flag system is not entirely free from the global scope. But I moved the big boolean out of the global scope. As time goes on, we will move more and more things out of the global scope.
This is part of the work from this discussion.
Checklist
doc/release/0.X.rst
) are up-to-date with any important changes.doc
folder.setup.py
.