(API Breaking) Finish removal of block.r

[albeanth]

What is the change?

This follows up on #909 and fully removes the block.r property. Leaving it causes some (imo) unnecessary tangling. So instead of the current

Reactor <--> Core <--> Assembly <--> Block <--> Component
   ^           ^                       |
   |-----------|-----------------------|

the following would be the new Composite relationships via properties

Reactor <--> Core <--> Assembly <--> Block <--> Component
               ^                       |
               |-----------------------|

Why is the change being made?

I can whip up some examples, but it causes some tangles with testing. Plug in the docstring it even says we should probably get rid of it. Plus you can still access the reactor object via b.core.

---

Checklist

• This PR has only one purpose or idea.
• Tests have been added/updated to verify that the new/changed code works.

• The code style follows good practices.
• The commit message(s) follow good practices.

• The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
• The documentation is still up-to-date in the doc folder.
• The dependencies are still up-to-date in pyproject.toml.

[albeanth]

Since this is an API change, it'll need to be run through the gamut of downstream tests.

[albeanth]

Converting to draft. This is looking like a fairly intrusive PR.

[albeanth]

The coverage report doesn't seem right again. I'm seeing the same coverage report results over several PRs. Something is fishy with coveralls. Any ideas?

[john-science]

The coverage report doesn't seem right again. I'm seeing the same coverage report results over several PRs. Something is fishy with coveralls. Any ideas?

Fixed.

[john-science]

Why are we moving this over to the other file?

How is this related to the block.r change?

[albeanth]

See the commit message for #1425 (comment).

TL/DR: Those methods called self.r.core which blocked the PR from going through. After grepping ARMI and one major downstream project, those methods never get called on any Composite other than Block. So those methods can safely be moved over to the Block class and self.r.core can get replaced with self.core.

[john-science]

Okay! As long as we call this out in the "API changes" section of the release notes!

[albeanth]

c2cd59d

[john-science]

To be clear, the reason I haven't tried to merge this is that we are currently in a code freeze. I am not ignoring you.

[albeanth]

I wasn't assuming you were. There's a whole bunch of downstream PRs for this so yeah, it'll be a little while before we can make movement on this. Feel free to mark as draft if you want, or close it. I can always reopen it later.

[john-science]

@albeanth This PR is getting a bit old; there are a bunch of conflicts.

Also, we should move the release note from 0.2.9 to 0.3.1.

[albeanth]

This PR is getting a bit old; there are a bunch of conflicts.

Also, we should move the release note from 0.2.9 to 0.3.1.

@john-science ok, the merge conflicts have been resolved and this feature branch is now up to date with main