Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing deprecated Database3.load() param #1434

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

john-science
Copy link
Member

What is the change?

Removed unused updateGlobalAssemNum param from Database3.load().

Why is the change being made?

This parameter has been unused (and explicitly deprecated) in ARMI for over a year now. And I recently succeeded in removing all downstream references to it in other projects.

It's finally time to remove this thing.


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Oct 16, 2023
@john-science
Copy link
Member Author

I ran downstream tests and they passed, so I'm merging.

@john-science john-science merged commit d3afb25 into main Oct 16, 2023
23 checks passed
@john-science john-science deleted the rm_updateGlobalAssemNum branch October 16, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants