Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions for impls in the blocks module #1619

Merged
merged 9 commits into from
Jan 25, 2024
Merged

Add descriptions for impls in the blocks module #1619

merged 9 commits into from
Jan 25, 2024

Conversation

keckler
Copy link
Member

@keckler keckler commented Jan 24, 2024

What is the change?

Adding longer implementation descriptions for the blocks module.

Why is the change being made?

Quality.


Checklist

  • The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
  • The documentation is still up-to-date in the doc folder.
  • If any requirements were affected, mention it in the release notes.
  • The dependencies are still up-to-date in pyproject.toml.

@keckler keckler marked this pull request as draft January 24, 2024 19:44
@albeanth albeanth added the documentation Improvements or additions to documentation label Jan 24, 2024
@albeanth
Copy link
Member

will reopen this when it's ready for review. Following this rule for @john-science https://github.com/terrapower/armi/blob/main/doc/developer/tooling.rst#dont-open-until-it-is-ready

@john-science
Copy link
Member

@keckler Closed? Is there a problem I should know about?

@albeanth albeanth reopened this Jan 24, 2024
@albeanth
Copy link
Member

@keckler Closed? Is there a problem I should know about?

@john-science #1619 (comment)

@albeanth albeanth marked this pull request as ready for review January 24, 2024 22:56
armi/reactor/blocks.py Outdated Show resolved Hide resolved
armi/reactor/blocks.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jyang-TP jyang-TP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review has finished.

@jyang-TP jyang-TP merged commit 161bc61 into main Jan 25, 2024
21 checks passed
@albeanth albeanth deleted the blocksImpls branch January 25, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants