Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding implementation details to geometryConverters #1621

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

TianJingwd
Copy link
Contributor

@TianJingwd TianJingwd commented Jan 24, 2024

What is the change?

This PR adds additional implementation details on the impl tags within geometryConverters

Why is the change being made?

SQA work


Checklist

  • The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
  • The documentation is still up-to-date in the doc folder.
  • If any requirements were affected, mention it in the release notes.
  • The dependencies are still up-to-date in pyproject.toml.

@CLAassistant
Copy link

CLAassistant commented Jan 24, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@albeanth albeanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments before handing this over to @opotowsky .

armi/reactor/converters/geometryConverters.py Outdated Show resolved Hide resolved
armi/reactor/converters/geometryConverters.py Outdated Show resolved Hide resolved
armi/reactor/converters/geometryConverters.py Outdated Show resolved Hide resolved
armi/reactor/converters/geometryConverters.py Outdated Show resolved Hide resolved
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think things read really well and represent the code. Just a few typos!

armi/reactor/converters/geometryConverters.py Outdated Show resolved Hide resolved
armi/reactor/converters/geometryConverters.py Outdated Show resolved Hide resolved
armi/reactor/converters/geometryConverters.py Outdated Show resolved Hide resolved
armi/reactor/converters/geometryConverters.py Outdated Show resolved Hide resolved
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All done -- great work and thank you @TianJingwd !

@TianJingwd TianJingwd merged commit 998dd9e into main Jan 25, 2024
21 checks passed
@john-science john-science deleted the impl_geometryConverters branch November 1, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants