Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using ruff to enforce that no line can be longer than 140 characters #1637

Merged
merged 5 commits into from
Feb 6, 2024

Conversation

john-science
Copy link
Member

What is the change?

This PR uses ruff to enforce that no line can be longer than 140 characters. (Check out the changes to the pyproject.toml file.)

Why is the change being made?

I would like to get ARMI down to 100 characters. But that will change about 1000 files (though mostly in minor ways). So, that's a big step.

I consider this PR a first step in that direction. I have also looked at making a next PR after this one, that reduces the maximum line length to 120 characters, that only touches ~100 files. I think that PR will follow this one.

There are no code changes in this PR, just formatting changes.


Checklist

  • The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
  • The documentation is still up-to-date in the doc folder.
  • If any requirements were affected, mention it in the release notes.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added enhancement New feature or request ci Related to continuous integration / github actions labels Jan 29, 2024
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I just request that this get merged AFTER the upcoming Examples fixes

Comment on lines -204 to +181
nuclide. Store these values in a
For a given composite object ``obj`` and a list of nuclides ``nuclides`` in that object,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes like this will cause more changes when you do the 120 line length update. S'all good, just wanted to call out this makes more work for future us

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be a limit of 100 characters, actually. Yeah, that's 96 characters.

@opotowsky
Copy link
Member

Ok we got the change in I wanted for the internal release so you can merge this one whenever you want!

@john-science john-science merged commit 571e4f5 into main Feb 6, 2024
21 checks passed
@john-science john-science deleted the line_length_140 branch February 6, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to continuous integration / github actions enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants