Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing Code Coverage #1656

Merged
merged 11 commits into from
Mar 4, 2024
Merged

Increasing Code Coverage #1656

merged 11 commits into from
Mar 4, 2024

Conversation

john-science
Copy link
Member

@john-science john-science commented Mar 4, 2024

What is the change?

I added code coverage to:

  • CaseSuite.compare()
  • Assembly.getBIndexFromZIndex()
  • Assembly.getElevationBoundariesByBlockType()

An I removed two unused methods:

  • Reactor.getAllNuclidesIn()
  • armi.utils.plotting.plotTriangleFlux()

Why is the change being made?

I am just trying to increase our code coverage.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added cleanup Code/comment cleanup: Low Priority testing Related to tests labels Mar 4, 2024
@john-science
Copy link
Member Author

john-science commented Mar 4, 2024

Geez. Moving the needle on our code coverage is hard these days. Here's the end result of this PR:

COVERAGE: 89.098% (+0.3%) FROM 88.827%

https://coveralls.io/builds/66071414

At least the code coverage is up over 89%.

Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just deleting unused code and adding a test outside a few non-requirements-associated docstring updated. Approve!

@john-science john-science merged commit 64351a0 into main Mar 4, 2024
21 checks passed
@john-science john-science deleted the code_cov_20240229 branch March 4, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority testing Related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants