-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increasing Code Coverage #1656
Increasing Code Coverage #1656
Conversation
Geez. Moving the needle on our code coverage is hard these days. Here's the end result of this PR:
https://coveralls.io/builds/66071414 At least the code coverage is up over 89%. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just deleting unused code and adding a test outside a few non-requirements-associated docstring updated. Approve!
What is the change?
I added code coverage to:
CaseSuite.compare()
Assembly.getBIndexFromZIndex()
Assembly.getElevationBoundariesByBlockType()
An I removed two unused methods:
Reactor.getAllNuclidesIn()
armi.utils.plotting.plotTriangleFlux()
Why is the change being made?
I am just trying to increase our code coverage.
Checklist
doc
folder.pyproject.toml
.