Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing TOX from ARMI #1683

Merged
merged 5 commits into from
Apr 9, 2024
Merged

Removing TOX from ARMI #1683

merged 5 commits into from
Apr 9, 2024

Conversation

john-science
Copy link
Member

What is the change?

Fully removed TOX from ARMI.

Why is the change being made?

No one is using TOX on their dev machines, which defeats the purpose of TOX. So, let's just simplify our CI.

Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added cleanup Code/comment cleanup: Low Priority ci Related to continuous integration / github actions labels Apr 8, 2024
@john-science john-science linked an issue Apr 8, 2024 that may be closed by this pull request
Move away from TOX #1676
Closed
@john-science john-science merged commit 5fffeb7 into main Apr 9, 2024
21 checks passed
@john-science john-science deleted the rm_tox branch April 9, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opotowsky opotowsky opotowsky approved these changes

Assignees
No one assigned
Labels
ci Related to continuous integration / github actions cleanup Code/comment cleanup: Low Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move away from TOX
2 participants
@john-science @opotowsky