Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the MacOS to CI #1713

Merged
merged 19 commits into from
May 24, 2024
Merged

Adding the MacOS to CI #1713

merged 19 commits into from
May 24, 2024

Conversation

john-science
Copy link
Member

@john-science john-science commented May 23, 2024

What is the change?

Adding the MacOS to CI.

Why is the change being made?

I recently found out that some of our users are Mac people.

Notes

  1. I can not immediately get our unit tests working in Mac in parallel (something about our test temp directory logic breaks). So, this PR only runs the unit tests in series.
  2. The Mac Unit Tests take 14 minutes to run. Is that too long?

Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the ci Related to continuous integration / github actions label May 23, 2024
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if you're happy with the run time!

Copy link
Member

@albeanth albeanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got an old macbook air from grad school lying around if you ever need more mac-specific testing.

If you're happy with the PR, push it through!

@john-science
Copy link
Member Author

john-science commented May 23, 2024

I've got an old macbook air from grad school lying around if you ever need more mac-specific testing.

I borrowed my wife's Mac. But I'm sure I'd love a second tester. Up to you! But it sounds like we've had Mac testers at USNC for years.

@john-science john-science merged commit 86247a9 into main May 24, 2024
23 checks passed
@john-science john-science deleted the mac_ci branch May 24, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to continuous integration / github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants