Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding code coverage #1735

Merged
merged 8 commits into from
Jun 18, 2024
Merged

Adding code coverage #1735

merged 8 commits into from
Jun 18, 2024

Conversation

john-science
Copy link
Member

What is the change?

Adding code coverage

Why is the change being made?

Trying to fight for 90%.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the testing Related to tests label Jun 18, 2024
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you'll have to find some test crumbs! The code changes look fine. I'll wait for the cleanup commit to approve

@john-science
Copy link
Member Author

john-science commented Jun 18, 2024

Ah! So close.

This PR takes the code coverage from 89.56 to 89.91.

Soooooo close!

@john-science john-science merged commit 7251796 into main Jun 18, 2024
23 checks passed
@john-science john-science deleted the fight_for_90 branch June 18, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants