-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating a one-block test reactor to speed up testing #1737
Merged
john-science
merged 23 commits into
terrapower:main
from
john-science:small_test_reactor
Jun 22, 2024
Merged
Creating a one-block test reactor to speed up testing #1737
john-science
merged 23 commits into
terrapower:main
from
john-science:small_test_reactor
Jun 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-science
added
testing
Related to tests
optimization
related to measuring and speeding up the code or reducing memory
labels
Jun 19, 2024
@opotowsky I reduced the scope of this PR for you. I moved the Hope that helps! |
opotowsky
approved these changes
Jun 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing! can't wait to use it downstream too!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
optimization
related to measuring and speeding up the code or reducing memory
testing
Related to tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
In this PR I created a test reactor from an existing single test block reactor:
armi/tests/smallestTestReactor/armiRunSmallest.yaml
Why is the change being made?
I am just trying to speed up our unit tests. (Close #1736)
On my personal laptop, I saw many unit tests go from between 2 or 6 seconds down to 0.1 to 0.2 seconds.
Perhaps more importantly, we now have the tooling to use across the ecosystem.
NOTE: Not all unit tests can use such a small reactor. Be design, if you are doing something like shuffling multiple assemblies, you can not use the smaller test reactor.
Checklist
doc
folder.pyproject.toml
.