Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a one-block test reactor to speed up testing #1737

Merged
merged 23 commits into from
Jun 22, 2024

Conversation

john-science
Copy link
Member

@john-science john-science commented Jun 19, 2024

What is the change?

In this PR I created a test reactor from an existing single test block reactor:

armi/tests/smallestTestReactor/armiRunSmallest.yaml

Using this new test reactor in dozens of tests, sped up our unit tests by 25-30%!

Why is the change being made?

I am just trying to speed up our unit tests. (Close #1736)

On my personal laptop, I saw many unit tests go from between 2 or 6 seconds down to 0.1 to 0.2 seconds.

Perhaps more importantly, we now have the tooling to use across the ecosystem.

NOTE: Not all unit tests can use such a small reactor. Be design, if you are doing something like shuffling multiple assemblies, you can not use the smaller test reactor.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added testing Related to tests optimization related to measuring and speeding up the code or reducing memory labels Jun 19, 2024
@john-science
Copy link
Member Author

@opotowsky I reduced the scope of this PR for you.

I moved the runLog.py fix and the Python 3.7 thing to another PR, which Tony got.

Hope that helps!

Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing! can't wait to use it downstream too!

@john-science john-science merged commit 2bcb036 into terrapower:main Jun 22, 2024
10 checks passed
@john-science john-science deleted the small_test_reactor branch June 22, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization related to measuring and speeding up the code or reducing memory testing Related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a super minimal test reactor, and use it to speed up our unit tests
2 participants