We shouldn't be wiping the global elements durint tests #1743
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
We have been calling
elements.factory()
during the unit tests, this PR removes that.Why is the change being made?
In some of our downstream unit testing, which is significantly more parallel, wiping the global
elements
object from memory, even temporarily, can cause other unit tests to fail.This has always been quite hard to track down, since it is an async bug that only happens very rarely. Happily, these calls were not necessary in the unit tests in the first place, so we can just remove them.
Checklist
doc
folder.pyproject.toml
.