Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We shouldn't be wiping the global elements durint tests #1743

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

john-science
Copy link
Member

What is the change?

We have been calling elements.factory() during the unit tests, this PR removes that.

Why is the change being made?

In some of our downstream unit testing, which is significantly more parallel, wiping the global elements object from memory, even temporarily, can cause other unit tests to fail.

This has always been quite hard to track down, since it is an async bug that only happens very rarely. Happily, these calls were not necessary in the unit tests in the first place, so we can just remove them.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added cleanup Code/comment cleanup: Low Priority testing Related to tests labels Jun 20, 2024
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy!! Nice work!

@john-science john-science marked this pull request as draft June 20, 2024 21:59
@john-science john-science marked this pull request as ready for review June 20, 2024 22:59
@john-science john-science merged commit 553629f into main Jun 20, 2024
23 checks passed
@john-science john-science deleted the elements_factory_problem branch June 20, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority testing Related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants