Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing unnecessary column in print-out #1925

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Removing unnecessary column in print-out #1925

merged 2 commits into from
Oct 4, 2024

Conversation

john-science
Copy link
Member

What is the change?

There is an incorrect and unused column in a summary table in the reactor blueprints, and this PR fixes it.

Why is the change being made?

I could have fixed the column to be correct, but since no one but Chris has EVER noticed it was broken, I infer the column is unused.

close #1192

Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the bug Something is wrong: Highest Priority label Oct 3, 2024
keckler
keckler approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@keckler keckler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right way to go. Thanks!

@john-science john-science merged commit 484c708 into main Oct 4, 2024
15 checks passed
@john-science john-science deleted the fix_summarizeMaterialData branch October 4, 2024 15:33
drewj-tp added a commit that referenced this pull request Oct 4, 2024
@drewj-tp
Merge remote-tracking branch 'origin/main' into drewj/block-input-height
ff6be0e 
* origin/main:
  Improving the robustness of  HexBlock._rotatePins() (#1859)
  Removing unnecessary column in print-out (#1925)
drewj-tp added a commit that referenced this pull request Oct 8, 2024
@drewj-tp
Merge remote-tracking branch 'origin/main' into drewj/improve-assem-a…
f02fca2 
…xial-linkage

* origin/main:
  Adding support for ex-core structures (#1891)
  Fixing edge case in assemblyBlueprint._checkParamConsistency (#1929)
  Improving the robustness of  HexBlock._rotatePins() (#1859)
  Removing unnecessary column in print-out (#1925)
  Updating parameter-related docs (#1919)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keckler keckler keckler approved these changes

Assignees
No one assigned
Labels
bug Something is wrong: Highest Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Property Data was Modified from the Source?"
2 participants
@john-science @keckler