Change geomType arguments to prefer GeomType enum #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also extracts the SystemLayoutInput class into its own module.
|
can you add a test that confirms |
Done! Yeah your issues were the main reason I made this PR. ALSO, lucky test 1,000 (I think)! 🎉 |
ntouran
approved these changes
Dec 18, 2020
Comment on lines
+311
to
+312
| self._geomType: geometry.GeomType | ||
| self.symmetry: str |
There was a problem hiding this comment.
woah weird. I see this is described here https://www.python.org/dev/peps/pep-0526/
and has no initial value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most code that takes a
geomTypeargument used to expect a string, which wouldbe tested against the string constants defined in the
geometrymodule. Thiswas error-prone, inefficient, and ambiguous. This adds some extra conversion
functionality to the GeomType enumeration class and changes most interfaces that
pass
geomTypearound to use instances of the GeomType enum instead. Somefunctions will still attempt a conversion from string to aid in backwards
compatibility, but these should be reduced moving forward.
Additionally, to better-organize the code in the geometry module, the
SystemLayoutInput class has been migrated to its own module.