Shem energy structure #238
Conversation
…rgies_with_group_lethargies
…source/armi-framework.git into shem_energy_structure
|
|
There was a problem hiding this comment.
approve with inline comment about comments. Can you also add another comment where the methods are called that says that these do run at import time which will eventually be a factor in armi import/startup time and that we probably should consider calling them in a more structured way during the armi bootstrap process?
|
|
||
| GROUP_STRUCTURE["SHEM361"] = [ |
There was a problem hiding this comment.
Can you just give a reference for SHEM361 in a comment here?
There was a problem hiding this comment.
@ntouran -- that's a good idea (its mildly tricky to find for free); here you go.
| @@ -275,14 +275,391 @@ def getGroupStructureType(neutronEnergyBoundsInEv): | |||
| ) | |||
|
|
|||
| # fmt: on | |||
| def _create_multigroup_structures_on_finegroup_energies( | |||
There was a problem hiding this comment.
interesting that we have camel_case functions in here. Anyway you're being consistent so we'll allow it!
This pull adds in the SHEM361 neutron energy group structure, generalizes the function to make a group structure that snaps to the boundaries of the ANL2081 structure to an arbitrary fine group structure and uses that function to make a 33 group structure -- SHEM33_361 -- that is like ANL33, but snapped to the boundaries of SHEM361.
This addresses issue #237