Broaden setting parsing error checking #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading a settings file that had a setting with an invalid value was not getting caught here because it was just a single invalid. This broadens the exception catching to capture any related validation error. Additionally the directory changer was changed to not make a separate error folder since most of the time migration type errors will be found in a local setting rather than while running on HPC.
youngmit
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading a settings file that had a setting with an invalid value was not
getting caught here because it was just a single invalid. This broadens
the exception catching to capture any related validation error.
Additionally the directory changer was changed to not make a separate
error folder since most of the time migration type errors will be found
in a local setting rather than while running on HPC.