NuclearDataIO and CCCC clean-ups #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provide any meaningful examples of its intended use or support. Grabbing MT and MF descriptions is quite easy to do from online and having these descriptions available in the framework does not add a lot of utility.
and only implements a dictionary compare method. The framework specifically provides no intended use cases or testing.
more general implementation of NHFLUX within the cccc files with the variant keyword argument set to True.
or GAMISO file within the __init__ of nuclearDataIO. It is preferred for client code to import direct paths to the specific CCCC objects.
jakehader
changed the title
ntouran
approved these changes
May 11, 2021
|
Oops something wrong with the unit tests though! |
ntouran
requested changes
May 11, 2021
`test_xsNuclides` after the removal of the `ISOTXS` function in the `nuclearDataIO` module. Now, the `isotxs.readBinary` function is called directly.
|
@ntouran, fixed the unit tests and tested locally. |
ntouran
approved these changes
May 11, 2021
jakehader
added
cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing some clean-ups to the
nuclearDataIOpackage (removing unused code) and incorporating some moredocumentation. The goal is to make a step in the direction of decoupling the
nuclearDataIOpackage from theARMI framework #259 and to do some general restructuring to start standardizing the documentation and testing
across #287.